azure - log and metric tweaks #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefangordon
force-pushed
the
loggingmetrics
branch
from
c855895
to
8fd2ebe
Compare
logachev
reviewed
Sep 27, 2019
| extra=self._get_action_log_metadata(resource)) | ||
|
|
||
| def _get_action_log_metadata(self, resource): | ||
| action = self.__class__.__name__ |
There was a problem hiding this comment.
I think it is better to use c7n registered action name rather than Python class name
| policy.ctx.metrics.put_metric( | ||
| 'ResourceCount', len(resources), 'Count', Scope="Policy", | ||
| buffer=False) | ||
|
|
||
| policy.ctx.metrics.put_metric( |
There was a problem hiding this comment.
I think we should upload metrics even if no resources were found (like 272 has early exit)
There was a problem hiding this comment.
Yeah pull mode does this, it breaks from lambda implementation further I think but that is fine. Fixing.
| @staticmethod | ||
| def _get_event_action(): | ||
| action = TestEventAction() | ||
| action.client = MagicMock() |
There was a problem hiding this comment.
nit: feels like it can be done in __init__() for test classes
logachev
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some logging and metrics improvements.
ResourceTimeandActionTimemetrics to event based policy executionlog.errorcalls which should belog.exceptioncalls (lots more to do here)I added a set of tests for the base action to cover logging and the new message result behavior, but this is still likely to be a patch coverage exception due to the number of exception handlers I updated which may not be necessary to test individually.