Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli - validate - structure parsing should exit 1 on error #5101

Merged
merged 1 commit into from
Nov 21, 2019
Merged

cli - validate - structure parsing should exit 1 on error #5101

merged 1 commit into from
Nov 21, 2019

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Nov 21, 2019

closes #5095

tjstansell
tjstansell approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@tjstansell tjstansell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround! And making sure there's a test.

@kapilt kapilt merged commit 46a5b22 into cloud-custodian:master Nov 21, 2019
@kapilt kapilt mentioned this pull request Jan 6, 2020
Merged
ajmsra pushed a commit to ajmsra/cloud-custodian that referenced this pull request Jan 14, 2020
@kapilt
cli - validate - structure parsing should exit 1 on error (cloud-cust…
df88c13 
…odian#5101)
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
@kapilt @fidelito
cli - validate - structure parsing should exit 1 on error (cloud-cust…
0211423 
…odian#5101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjstansell tjstansell tjstansell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate exits with status 0 with structural parser errors.
2 participants
@kapilt @tjstansell