Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMI filtering shouldn't expect a LaunchTemplate version #5161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sutto
Copy link
Contributor

@Sutto Sutto commented Dec 11, 2019

We've seen data where the LaunchTemplate (on the ASG directly)
has no version attribute at all - so we should use .get with a default
of None instead, to avoid raising an exception.

We've seen data where the LaunchTemplate (on the ASG directly)
has no version attribute at all - so we should use .get with a default
of None instead, to avoid raising an exception.
@Sutto Sutto marked this pull request as ready for review December 11, 2019 02:08
@kapilt
Copy link
Collaborator

kapilt commented Dec 11, 2019

thanks for the pr, I assume no version specified implies latest template version for the asg, but then using a none key here afaics will result in not finding the associated template for the asg. we'll need some additional logic to enable an asg <-> latest template version match.

@kapilt
Copy link
Collaborator

kapilt commented Dec 11, 2019

afaics we can just above when building up a list of template versions, we can also inject the template version None for the latest version to enable a match.

@Sutto
Copy link
Contributor Author

Sutto commented Dec 13, 2019

Yeh, I'm trying to track down the specific cause of a None template version, but I'm guessing it
's latest (the docs specifically call out a special value, but it's a different one). I'm gonna try and track it down a bit more and update, as well as adding some tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants