add defaults to securityhub's post-finding action schema documentation #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Jan 3, 2020
c7n/resources/securityhub.py
Outdated
| severity={"type": "number", 'default': 0}, | ||
| severity_normalized={"type": "number", "min": 0, "max": 100, 'default': 0}, | ||
| confidence={"type": "number", "min": 0, "max": 100}, | ||
| criticality={"type": "number", "min": 0, "max": 100}, | ||
| # Cross region aggregation | ||
| region={'type': 'string', 'description': 'cross-region aggregation target'}, | ||
| region={'type': 'string', 'description': 'cross-region aggregation target', | ||
| 'default': 'current region'}, |
There was a problem hiding this comment.
hmm.. default of current region and the description don't quite logically go together. default none or no-aggregation would be better.
Revert default for region
ajmsra
pushed a commit
to ajmsra/cloud-custodian
that referenced
this pull request
Jan 14, 2020
fidelito
pushed a commit
to fidelito/cloud-custodian
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple adding of documentation of 4 default values to the securityhub post-finding schema