Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws - security hub - hub modes support cross account execution #5230

Merged
merged 8 commits into from
Jan 18, 2020

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Jan 14, 2020

closes #5034

todo (not required, just optimizations)

  • check if the finding is in the same account/region and if so don't bother with role assume
  • try to sort the resource sets so that same account / master shows up first, and then the rest are ordered per by account_id, and region.

@kapilt kapilt marked this pull request as ready for review January 15, 2020 20:23
@kapilt kapilt force-pushed the aws/hub-mode-cross-account branch 2 times, most recently from 0b18afa to a0ff310 Compare January 17, 2020 13:49
@FireballDWF FireballDWF self-requested a review January 18, 2020 15:51
Copy link
Collaborator

@FireballDWF FireballDWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I've independently tested

@FireballDWF FireballDWF merged commit fa47a27 into cloud-custodian:master Jan 18, 2020
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
…-custodian#5230)

* aws - security hub - hub modes support cross account execution

* stop execution if we see resources from a different account and are not configured for member-role/multi-account instead of just warning

* if we don't have any matching resource arns stop and log early
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross account Security Hub remediation
2 participants