C7n org regioncheck update #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the pr and flagging this. The fix here is actually to just remove this check. ie. p.region is not the same as p.config.region.. p.region was a conditional execution check, where as config.region is a requested region to execute the policy against. p.region and other condition attributes are no longer exposed, partly because they were non obvious pollution of the policy attributes, instead they are converted to conditions. re the fix, just remove these lines, policy.conditions are evaluated internal to a policy.run. |
|
Awesome! That makes things even easier :) so much history in this tool haha. As usual, thanks for the explanation. I also submitted a small addition to the tests where I noticed a likely intended assertion missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address an issue from PolicyCollection change in #4466
Looks like region is being set to the policy.config.region instead of policy.region now and this line is throwing an error when running c7n-org. I believe this can be traced back to changes made in #4466.