Python 2 to 3 updates #5528
Merged
Python 2 to 3 updates #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsc27
force-pushed
the
py3-update
branch
3 times, most recently
from
4ea9ebd
to
38840bd
Compare
|
you'll need to backout changes to tools/c7n_mailer to pass ci, or add additional unit tests to that package, per #5521 mailer has had low test coverage historically, to effect movement towards resolving that, changes to that package typically require adding additional tests. |
|
Hey @CMeza99 I should have the code cov up in the next day or so if you want to wait on it. Will message when it's resolved. |
|
Thank you @kapilt and @JohnHillegass ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quick Py3 updates:
import __future__