cli - fix schema output with no args, remove argcompletion around schema #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnHillegass
previously approved these changes
Apr 17, 2020
|
looks like there are a few issues in test_cli where it is looking for the schema completer. Other than that, looks good! |
JohnHillegass
approved these changes
Apr 17, 2020
fidelito
pushed a commit
to fidelito/cloud-custodian
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5599 had a regression for the no arg case which was being caught by the docker image testing.
argcompletion around schema command, was also bitrotted so removing for now, we can do better with a shell in the future.