Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - account - set password policy #5634

Merged
merged 17 commits into from Apr 23, 2020
Merged

aws - account - set password policy #5634

merged 17 commits into from Apr 23, 2020

Conversation

JohnHillegass
Copy link
Collaborator

@JohnHillegass JohnHillegass commented Apr 22, 2020 •
edited

For #5592

@JohnHillegass JohnHillegass marked this pull request as draft April 22, 2020 02:48
@JohnHillegass JohnHillegass linked an issue Apr 22, 2020 that may be closed by this pull request
Can not set password policy at the aws account level? #5592
Closed
@JohnHillegass
Copy link
Collaborator Author

Closing this for now, will reopen once the work is completed

@JohnHillegass JohnHillegass reopened this Apr 22, 2020
@JohnHillegass JohnHillegass marked this pull request as ready for review April 22, 2020 14:59
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Apr 22, 2020
View reviewed changes
c7n/resources/account.py Outdated Show resolved Hide resolved
kapilt
kapilt approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 3839245 into cloud-custodian:master Apr 23, 2020
@JohnHillegass JohnHillegass deleted the 5592-aws-account-set-password-policy branch April 23, 2020 13:55
@JohnHillegass JohnHillegass mentioned this pull request Apr 30, 2020
Closed
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
@JohnHillegass @fidelito
aws - account - set password policy (cloud-custodian#5634)
ae27d7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not set password policy at the aws account level?
2 participants
@JohnHillegass @kapilt