AWS - streaming_distribution set-attributes action and config filter #5694
Conversation
|
Hi Kapil, can you expand on what you mean by refactor to a base class / what exactly shouldn't be duplicated? The required fields in update_streaming_distribution() and update_distribution() are different as well as the exceptions they throw. Also distribution and streaming-distribution were already classified as different resources, so I'm not sure on how to more refactor the code. Thanks! |
parameterize the parts that are different, and let the base class use that to do the legwork, subclasses just become setting class attributes. also on name this should be distribution-config, its already qualified to the streaming distribution, so the prefix is redundant. |
|
Ok, I tried refactoring the distribution-config filter and the set-attributes action to a base class as you said. Let me know if I should also factor out the augment and process_distribution methods - I thought they looked kind of messy taking 5 or 6 arguments in the base class and I didn't know how to properly pass the client methods without creating duplicate clients. I also made the required fields to be a class attribute as you suggested. |
Add a set-attributes action for streaming distributions, as well as a streaming-distribution-config filter. I also included two bug fixes for regular Cloudfront distributions: one where I wasn't properly using the distribution-config filter in the tests, and the other where I didn't set the 'Comment' and 'Enabled' required fields if they were not included in the attributes part of the policy.