SQS VPC Endpoint in c7n_mailer issue 5722 #5770
Merged
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the pull request, github actions seems to be having issues atm. |
kapilt
reviewed
May 19, 2020
tools/c7n_mailer/README.md
Outdated
| @@ -257,6 +257,7 @@ and here is a description of the options: | |||
| |:---------:|:----------------|:-----------------|:------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | ✅ | `queue_url` | string | the queue to listen to for messages | | |||
| | | `from_address` | string | default from address | | |||
| | | `endpoint_url` | string | The complete URL to use for the constructed client. | | |||
There was a problem hiding this comment.
minor doc string here, probably should read - SQS API URL (for use with VPC Endpoints)
kapilt
reviewed
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue 5722 attempting to add in the endpoint_url into the configuration and have it part of the session's client call. If it is not defined, it will default to null and in the call will be = to None which is what https://boto3.amazonaws.com/v1/documentation/api/latest/reference/core/session.html
seems to be expecting. Added in documentation change.