aws - config workaround broken select resource api and normalize rds cluster snapshot #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and normalize rds cluster snapshot
kapilt
changed the title
kapilt
changed the title
fidelito
pushed a commit
to fidelito/cloud-custodian
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5780
as noted in #5408 config is fairly arbitrary with regard to what it supports for a given resource type. for many resource type that it documents as supporting, it doesn't actually support resource select api, how arbitrary it is on being broken is unclear (ie. does it vary just by type or also include other mystery variations by account, region, time of day). fallback to our old way of handling this pre select resources api, of just iterating ids and fetching fo resource types where we're not able to get results via select resources. on empty sets this does involve an extra api query per region.
also handle the particularly mangled db cluster snapshot identifiers, and normalize them back to describe format.