New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws - Remove matched statement for glue-catalog #5808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @PratMis! Would it make sense to also add a modify-policy action as well, similar to what was done for SNS/SQS? I have a has statements filter in flight which might compliment it well later
Absolutely @JohnHillegass ! it would make sense to have it for catalog. I'll queue it up for follow up PRs. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
This PR adds functionality to remove matched statement in glue-catalog resource policy.
Sample Policy
I had to manually edit the external account_id in the policy since it gets replaced by the default account_id. Also, if there are no statements left in the policy, glue doesn't allow usage of put_resource_policy(), hence I had to use delete_resource_policy()