Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws - action to remove create volume permissions from a snapshot #6203

Conversation

dnouri
Copy link
Contributor

@dnouri dnouri commented Oct 12, 2020

Fixes #6080

c7n/resources/ebs.py Outdated Show resolved Hide resolved
@dnouri dnouri force-pushed the aws/ebs-snapshot-remove-create-volume-permissions branch from f68da33 to aa1a324 Compare October 12, 2020 14:49
@dnouri dnouri marked this pull request as ready for review October 13, 2020 10:55
@dnouri dnouri requested a review from kapilt as a code owner October 13, 2020 10:55
c7n/resources/ebs.py Outdated Show resolved Hide resolved
@dnouri dnouri force-pushed the aws/ebs-snapshot-remove-create-volume-permissions branch 2 times, most recently from 745ac36 to 6f5c2c4 Compare October 14, 2020 23:54
@dnouri dnouri force-pushed the aws/ebs-snapshot-remove-create-volume-permissions branch from 6f5c2c4 to e8fd700 Compare October 15, 2020 11:42
c7n/resources/ebs.py Outdated Show resolved Hide resolved
@dnouri dnouri force-pushed the aws/ebs-snapshot-remove-create-volume-permissions branch from 08043e9 to 8918281 Compare October 20, 2020 10:21
c7n/resources/ebs.py Outdated Show resolved Hide resolved
@kapilt kapilt force-pushed the aws/ebs-snapshot-remove-create-volume-permissions branch from e376fc9 to caba487 Compare December 3, 2020 10:36
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 4613f38 into cloud-custodian:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to remove cross-account access to EBS snapshots for matched account IDs
2 participants