Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing - do not skip doc examples tests by default #6222

Merged

Conversation

dnouri
Copy link
Contributor

@dnouri dnouri commented Oct 15, 2020

No description provided.

@dnouri dnouri force-pushed the dont-skip-doc-examples-by-default branch from 6155bd5 to ec4a068 Compare October 15, 2020 19:48
tests/test_doc_examples.py Outdated Show resolved Hide resolved
@kapilt
Copy link
Collaborator

kapilt commented Oct 20, 2020

this originated when running doc tests was super slow, the lazy loading and schema generation work make these tests relatively fast now.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 894367f into cloud-custodian:master Oct 21, 2020
@dnouri dnouri deleted the dont-skip-doc-examples-by-default branch October 21, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants