Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure - VM - action to resize vm #6247

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

danmarcab
Copy link
Contributor

This PR adds the azure.vm.actions.resize action.

It is my first contribution and python is not my first language so suggestions are very welcome.

Trying to run the test suite I found a couple of other minor things:

  • Deprecation warning in provision.sh script
  • The vm.json template was not using the variable and was hardcoded to a non supported size
  • The example for the azure.vm.actions.delete had a misleading name

Not sure if they are ok to be merged like this or you prefer separate PRs, they are in different commits so easily done if needed.

@kapilt
Copy link
Collaborator

kapilt commented Oct 27, 2020

Thanks for the pull request! This looks great, as a first step, If you don't mind, could you sign the CLA per the developer docs? Direct link here: https://docs.google.com/forms/d/e/1FAIpQLSfwtl1s6KmpLhCY6CjiY8nFZshDwf_wrmNYx1ahpsNFXXmHKw/viewform

We're in process on switching out to the cncf.io easycla system, but thats likely going to be another month in transition.

@danmarcab
Copy link
Contributor Author

Sure @kapilt, I've just filled the form 👍

Copy link
Contributor

@h-dub h-dub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 3fcb56a into cloud-custodian:master Nov 3, 2020
@h-dub
Copy link
Contributor

h-dub commented Nov 3, 2020

note: old az installs will need an update to work with the provision.sh changes. 2.14.0 works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants