c7n-org fix resolve regions when all is set #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Nov 12, 2020
|
there's one other use of resolve_regions in c7n-trailcreator that needs updating |
|
@kapilt Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the 'resolve_regions' use the default boto3 credentials to get available regions when the region parameter is set to 'all'. This generates an error(botocore.exceptions.ClientError: An error occurred (RequestExpired) when calling the DescribeRegions operation: Request has expired) when the default AWS profile is not configured(my case) and doesn't check the targeted account(the result can be different depending on the enabled regions).