Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - iam certificate - add delete action #6288

Merged
merged 9 commits into from Dec 1, 2020
Merged

aws - iam certificate - add delete action #6288

merged 9 commits into from Dec 1, 2020

Conversation

dnouri
Copy link
Contributor

@dnouri dnouri commented Nov 12, 2020

Consider the action in this example:

        - name: aws-iam-certificate-delete-expired
          resource: iam-certificate
          filters:
            - type: value
              key: Expiration
              value_type: expiration
              op: greater-than
              value: 0
          actions:
            - type: delete

@dnouri dnouri requested a review from kapilt as a code owner November 12, 2020 14:55
@dnouri dnouri marked this pull request as draft November 12, 2020 14:55
kapilt
kapilt reviewed Nov 12, 2020
View reviewed changes
c7n/resources/iam.py Outdated Show resolved Hide resolved
kapilt
kapilt reviewed Nov 12, 2020
View reviewed changes
tests/test_iam.py Outdated Show resolved Hide resolved
kapilt
kapilt requested changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments inline

@kapilt kapilt marked this pull request as ready for review December 1, 2020 13:54
@kapilt kapilt changed the title [WIP] Add action to delete iam server cert aws - iam certificate - add delete action Dec 1, 2020
kapilt
kapilt approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

marcoceppi
marcoceppi approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@marcoceppi marcoceppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapilt kapilt merged commit 641f95a into cloud-custodian:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

@marcoceppi marcoceppi marcoceppi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dnouri @kapilt @marcoceppi @h-dub