Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws - rds - remove tag augmentation where builtin #6332

Merged
merged 1 commit into from Dec 9, 2020

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Dec 8, 2020

Closes #6330

Per https://awsapichanges.info/archive/changes/5fc292-rds.html
many rds resources now support tags in their default describe outputs
so custodian no longer needs to query for them separatel.

@kapilt kapilt marked this pull request as ready for review December 9, 2020 14:14
@kapilt kapilt force-pushed the aws/rds-tag-augment-revisit branch from e1b95cb to 80cbd0d Compare December 9, 2020 14:22
@kapilt kapilt force-pushed the aws/rds-tag-augment-revisit branch from 80cbd0d to 46e7d0f Compare December 9, 2020 14:33
@kapilt
Copy link
Collaborator Author

kapilt commented Dec 9, 2020

the coverage decrease being reported by codecov here is bogus afaics.

@kapilt kapilt merged commit 19e9a3e into cloud-custodian:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws - rds - remove tag augmentation
1 participant