Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci - fix for functional test on log region 4 terraform #6341

Merged
merged 1 commit into from Dec 9, 2020
Merged

ci - fix for functional test on log region 4 terraform #6341

merged 1 commit into from Dec 9, 2020

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Dec 9, 2020

fix for functional run, terraform was targeting us-east-1 but policy was targeting us-west-2


@kapilt kapilt marked this pull request as ready for review December 9, 2020 23:38
marcoceppi
marcoceppi reviewed Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@marcoceppi marcoceppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to re-record the flight data for terraform with the name change?

marcoceppi
marcoceppi approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@marcoceppi marcoceppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second thought, as long as the flight data is consistent in tree, it shouldn't matter

h-dub
h-dub approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@h-dub h-dub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapilt kapilt merged commit d3af485 into cloud-custodian:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoceppi marcoceppi marcoceppi approved these changes

@h-dub h-dub h-dub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kapilt @marcoceppi @h-dub