Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws.ecs-task-definition | config support #6561

Merged
merged 11 commits into from Apr 3, 2021

Conversation

PratMis
Copy link
Collaborator

@PratMis PratMis commented Mar 22, 2021

Closes #6506

note: Response received from AWS config doesn't seem consistent with the boto3 response. Hence, I had to override the response to add taskDefinitionArn key that's used in all ecs-task-definition actions(tag/remove-tag/delete).

@PratMis PratMis requested a review from kapilt as a code owner March 22, 2021 14:21
@PratMis PratMis marked this pull request as draft March 22, 2021 14:29
@PratMis PratMis marked this pull request as ready for review March 22, 2021 15:43
c7n/resources/ecs.py Outdated Show resolved Hide resolved
c7n/resources/ecs.py Outdated Show resolved Hide resolved
@PratMis
Copy link
Collaborator Author

PratMis commented Mar 22, 2021

@kapilt
Copy link
Collaborator

kapilt commented Mar 22, 2021

@kapilt looks ECS hasn't made it here yet: https://github.com/boto/botocore/blob/a8d13bb5b70283f69dd518f277b050a86a40a794/botocore/data/config/2014-11-12/service-2.json#L6238 and its causing the test to fail

you should be able to file a support request with the service team via your tam on that. the service team controls those files. its also possible that maybe config support for ecs isn't fully baked if its not in that resource type list which is needed for some api interactions as its used to validate parameters.

@kapilt
Copy link
Collaborator

kapilt commented Mar 22, 2021

alternatively we maintain a list of various resources that config supports but hasn't bothered to update its sdk correctly for that we explicitly check in this test.

@PratMis
Copy link
Collaborator Author

PratMis commented Mar 23, 2021

@kapilt looks ECS hasn't made it here yet: https://github.com/boto/botocore/blob/a8d13bb5b70283f69dd518f277b050a86a40a794/botocore/data/config/2014-11-12/service-2.json#L6238 and its causing the test to fail

you should be able to file a support request with the service team via your tam on that. the service team controls those files. its also possible that maybe config support for ecs isn't fully baked if its not in that resource type list which is needed for some api interactions as its used to validate parameters.

Thanks @kapilt! Trying to bring this up to our TAM. Will keep you posted.

@PratMis
Copy link
Collaborator Author

PratMis commented Mar 23, 2021

linking botocore issue: boto/botocore#2323

@kapilt
Copy link
Collaborator

kapilt commented Apr 3, 2021

i've updated the pr to correctly normalize and to work around the config service sdk issue.

@kapilt kapilt merged commit b846a03 into cloud-custodian:master Apr 3, 2021
@PratMis
Copy link
Collaborator Author

PratMis commented Apr 3, 2021

oops, sorry i didn't get back to this thinking AWS would have to fix boto before we could merge this PR. Thanks @kapilt 👍

@PratMis PratMis deleted the ecs-config branch April 3, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config support for ECS
2 participants