Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws - ec2 svc id prefix for more resources #6566

Merged
merged 3 commits into from Mar 29, 2021

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Mar 23, 2021

multi resource events (ala create tags), need an id_prefix
distinction for disambiguation.


@kapilt kapilt marked this pull request as ready for review March 24, 2021 19:21
Copy link
Collaborator

@JohnHillegass JohnHillegass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JohnHillegass
Copy link
Collaborator

@kapilt what do you think about adding some more docs around event pattern matching? Was recently playing with something like this to only invoke on changes to certain tags.

      - name: detect-changes-to-only-certain-tags
        resource: aws.subnet
        mode:
          type: cloudtrail
          role: CustodianDemoRole
          events:
            - source: ec2.amazonaws.com
              event: CreateTags
              ids: requestParameters.resourcesSet.items[].resourceId
            - source: ec2.amazonaws.com
              event: DeleteTags
              ids: requestParameters.resourcesSet.items[].resourceId
          pattern:
            detail:
              requestParameters:
                resourcesSet:
                  items:
                    resourceId:
                      - prefix: sg-
                tagSet:
                  items:
                    key:
                      - prefix: c7n-
                      - MyTag

@kapilt
Copy link
Collaborator Author

kapilt commented Mar 25, 2021 via email

@kapilt kapilt merged commit 85e82a7 into cloud-custodian:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants