Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - Add example to AWS Tag Action #6653

Merged
merged 2 commits into from Apr 28, 2021
Merged

Docs - Add example to AWS Tag Action #6653

merged 2 commits into from Apr 28, 2021

Conversation

trastle
Copy link
Contributor

@trastle trastle commented Apr 27, 2021

Docs only - Add an example to the docs block of the AWS tag action.

@trastle
Docs - Add example to AWS Tag Action
a11143e 
Docs only - Add an example to the docs block of the AWS tag action.
@trastle trastle requested a review from kapilt as a code owner April 27, 2021 13:53
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 27, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@trastle
Copy link
Contributor Author

trastle commented Apr 28, 2021

@kapilt should I open an Issue to discuss contributing to the docs for this?
I can't quite tell from the contributor guide if an Issue is needed for trivial changes like this.

@kapilt
Copy link
Collaborator

kapilt commented Apr 28, 2021

@kapilt should I open an Issue to discuss contributing to the docs for this?
I can't quite tell from the contributor guide if an Issue is needed for trivial changes like this.

nope not needed for doc updates, or minor bug fixes. thanks for the pr!

kapilt
kapilt approved these changes Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit c08e27f into cloud-custodian:master Apr 28, 2021
@trastle
Copy link
Contributor Author

trastle commented Apr 30, 2021

Thanks for the review and merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trastle @kapilt