Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure - new resources #6759

Merged
merged 3 commits into from Jun 22, 2021
Merged

azure - new resources #6759

merged 3 commits into from Jun 22, 2021

Conversation

stefangordon
Copy link
Collaborator

@stefangordon stefangordon commented Jun 21, 2021 •
edited

A batch of new resources.

policies:
  - name: frontdoor
    resource: azure.front-door
  - name: application-gateway
    resource: azure.application-gateway
  - name: logic-app-workflow
    resource: azure.logic-app-workflow
  - name: mysql
    resource: azure.mysql
  - name: service-fabric-cluster
    resource: azure.service-fabric-cluster
  - name: service-fabric-cluster-managed
    resource: azure.service-fabric-cluster-managed
  - name: traffic-manager-profile
    resource: azure.traffic-manager-profile

Also

  • Cleanup soft delete resources in provisioning script
  • Remove outdated/unnecessary Azure install instructions (the root instructions cover all clouds and these don't actually work due to setup.py not being frozen).

erwelch
erwelch approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@erwelch erwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

logachev
logachev approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@logachev logachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comments

tools/c7n_azure/c7n_azure/resources/mysql.py Outdated
"""

class resource_type(ArmResourceManager.resource_type):
doc_groups = ['Compute']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have databases doc group: https://cloudcustodian.io/docs/azure/resources/group-databases.html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch

tools/c7n_azure/tests_azure/tests_resources/test_app_gateway.py Outdated
super(ApplicationGatewayTest, self).setUp()

def test_app_gateway_validate(self):
with self.sign_out_patch():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: iirc, we don't really need this with.. Might be wrong, was a long time ago.

tools/c7n_azure/tests_azure/tests_resources/test_app_gateway.py Outdated


class ApplicationGatewayTest(BaseTest):
def setUp(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd just remove empty methods (and other tests too)

@stefangordon stefangordon merged commit 38c33aa into cloud-custodian:master Jun 22, 2021
@stefangordon
Copy link
Collaborator Author

Closes #6718 #6717 #6716 #6712 #6711 #6710

@ajkerrigan ajkerrigan mentioned this pull request Jul 8, 2021
Open
aq17 pushed a commit to draios/cloud-custodian that referenced this pull request Jul 26, 2021
@stefangordon
azure - new resources (cloud-custodian#6759)
efa02bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logachev logachev logachev approved these changes

@erwelch erwelch erwelch approved these changes

@kapilt kapilt Awaiting requested review from kapilt

Assignees
No one assigned
Labels
provider/azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefangordon @logachev @erwelch