fix: skip incorrect action_date instead of failing c7n

c7n/resources/opsworks.py

@@ -64,7 +64,7 @@ def process_stack(self, stack):
             instances = client.describe_instances(StackId=stack_id)['Instances']
             orig_length = len(instances)
             instances = self.filter_resources(instances, 'Status', self.valid_origin_states)
-            if(len(instances) != orig_length):
+            if len(instances) != orig_length:
                 self.log.exception(
                     "All instances must be stopped before deletion. Stack Id: %s Name: %s." %
                     (stack_id, stack['Name']))

c7n/resources/rds.py

@@ -1825,7 +1825,8 @@ class resource_type(TypeInfo):
 
 @filters.register('consecutive-snapshots')
 class ConsecutiveSnapshots(Filter):
-    """Returns instances where number of consective daily snapshots is equal to/or greater than n days.
+    """Returns instances where number of consective daily snapshots is
+    equal to/or greater than n days.
 
     :example:
 

c7n/resources/ssm.py

@@ -719,7 +719,7 @@ def process(self, resources):
                         AccountIdsToRemove=r['c7n:CrossAccountViolations']
                     )
                 except client.exceptions.InvalidDocumentOperation as e:
-                    raise(e)
+                    raise e
         else:
             for r in resources:
                 try:
@@ -730,7 +730,7 @@ def process(self, resources):
                         AccountIdsToRemove=remove_accounts
                     )
                 except client.exceptions.InvalidDocumentOperation as e:
-                    raise(e)
+                    raise e
 
 
 @SSMDocument.action_registry.register('delete')
@@ -783,7 +783,7 @@ def process(self, resources):
                         Force=True
                     )
                 else:
-                    raise(e)
+                    raise e
 
 
 @resources.register('ssm-data-sync')

c7n/resources/vpc.py

@@ -2078,7 +2078,7 @@ def process_attached(self, client, associated_addrs):
                 client.disassociate_address(AssociationId=aa['AssociationId'])
             except ClientError as e:
                 # If its already been diassociated ignore, else raise.
-                if not(e.response['Error']['Code'] == 'InvalidAssocationID.NotFound' and
+                if not (e.response['Error']['Code'] == 'InvalidAssocationID.NotFound' and
                        aa['AssocationId'] in e.response['Error']['Message']):
                     raise e
                 associated_addrs.remove(aa)

c7n/tags.py

@@ -314,6 +314,7 @@ def __call__(self, i):
         except Exception:
             self.log.warning("could not parse tag:%s value:%s on %s" % (
                 tag, v, i['InstanceId']))
+            return False
 
         if self.current_date is None:
             self.current_date = datetime.now()

c7n/utils.py

@@ -523,7 +523,7 @@ def reformat_schema(model):
     ret = copy.deepcopy(model.schema['properties'])
 
     if 'type' in ret:
-        del(ret['type'])
+        del ret['type']
 
     for key in model.schema.get('required', []):
         if key in ret: