Fix for VPC FlowLog issue #7648 #7654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
dismissed
their stale review
might have jumped the gun, needs to pass tests first
thisisshi
requested changes
Aug 19, 2022
scoleri
commented
Aug 22, 2022
Co-authored-by: Sonny <sonny@stacklet.io>
ajkerrigan
reviewed
Aug 31, 2022
| fl['LogDestination'] = '' | ||
| dest_match = (destination is None) or op( | ||
| fl['LogDestination'], destination) | ||
| if fl.get('LogDestinationType') == "s3": |
There was a problem hiding this comment.
Looks like this change will prevent the filter from being able to test cloudwatch destinations. I'm wondering if the original code was close, but needed fl['LogDestination'] --> fl.get('LogDestination') to avoid the KeyError you were seeing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7648