-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng - ci - add AWS functional tests to github actions, fix FTs #7733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisshi
changed the title
releng - ci - add AWS functional tests to github actions, fix FTs #12
releng - ci - add AWS functional tests to github actions, fix FTs
Sep 4, 2022
kapilt
reviewed
Sep 6, 2022
kapilt
reviewed
Sep 7, 2022
kapilt
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm
ritch2022
pushed a commit
to ritch2022/cloud-custodian
that referenced
this pull request
Oct 13, 2022
HappyKid117
pushed a commit
to HappyKid117/cloud-custodian
that referenced
this pull request
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Github Actions job that runs at 6 AM UTC or 2 AM EST/11 PM PST that runs the AWS functional tests, this PR also includes some fixes that address some of the common problems with running the functional tests in the same environment over and over again, namely IAM resource name conflicts.
Also includes some minor bug fixes for some of the functional tests:
This PR also requires that the secret
AWS_ROLE_ARN
be set and the corresponding role and identity pool be created to support the Github OIDC auth flow. Docs here: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-servicesFollow up PRs for GCP and Azure will come later
Example successful test: https://github.com/thisisshi/cloud-custodian/runs/8214994814?check_suite_focus=true