Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng - ci - add AWS functional tests to github actions, fix FTs #7733

Merged
merged 43 commits into from
Sep 9, 2022

Conversation

thisisshi
Copy link
Member

@thisisshi thisisshi commented Sep 4, 2022

This PR adds a new Github Actions job that runs at 6 AM UTC or 2 AM EST/11 PM PST that runs the AWS functional tests, this PR also includes some fixes that address some of the common problems with running the functional tests in the same environment over and over again, namely IAM resource name conflicts.

Also includes some minor bug fixes for some of the functional tests:

  • EC2 DisableApiStop was preventing terraform from removing the instances after they were created
  • The S3 IAM Analyzer test was missing an arg for pytest-terraform

This PR also requires that the secret AWS_ROLE_ARN be set and the corresponding role and identity pool be created to support the Github OIDC auth flow. Docs here: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services

Follow up PRs for GCP and Azure will come later

Example successful test: https://github.com/thisisshi/cloud-custodian/runs/8214994814?check_suite_focus=true

@thisisshi thisisshi changed the title releng - ci - add AWS functional tests to github actions, fix FTs #12 releng - ci - add AWS functional tests to github actions, fix FTs Sep 4, 2022
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@kapilt kapilt merged commit cbc17b3 into cloud-custodian:master Sep 9, 2022
ritch2022 pushed a commit to ritch2022/cloud-custodian that referenced this pull request Oct 13, 2022
HappyKid117 pushed a commit to HappyKid117/cloud-custodian that referenced this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants