c7n_tencentcloud - tests - support vcr for flight recording #7735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
changed the title
kapilt
reviewed
Sep 8, 2022
| jsonpath = "Response.Products[]" | ||
| resp = simple_client.execute_query(action, {}) | ||
| data = jmespath.search(jsonpath, resp) | ||
| assert data |
There was a problem hiding this comment.
can this assert additionally some value in the data?
There was a problem hiding this comment.
the original idea is just checking whether there is a value.
sure, will add some value next time
kapilt
reviewed
Sep 8, 2022
kapilt
reviewed
Sep 8, 2022
| @@ -257,9 +261,9 @@ def get_resource_tag(self, resource): | |||
| }) | |||
| return result | |||
|
|
|||
| def get_resource6(self, resource_id): | |||
| def get_resource_qcs(self, resource_id): | |||
kapilt
reviewed
Sep 8, 2022
kapilt
reviewed
Sep 8, 2022
.github/workflows/ci-main.yml
Outdated
| @@ -108,7 +108,7 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| make sphinx | |||
|
|
|||
ritch2022
added a commit
to ritch2022/cloud-custodian
that referenced
this pull request
Oct 13, 2022
HappyKid117
pushed a commit
to HappyKid117/cloud-custodian
that referenced
this pull request
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.