aws - rest-stage - add regex match support for wafv2-enabled filter and set-wafv2 action #7946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cfgperiodic
mu - changes on LambdaRetry max_attempts
Also rename/shorten the ignore parameter for readability.
kapilt
reviewed
Oct 31, 2022
| re.match(target_acl, k)] | ||
| if len(target_acl_ids) != 1 or \ | ||
| ('arn' not in target_acl_ids[0]): | ||
| raise ValueError(f'{target_acl} matching to none or the ' |
There was a problem hiding this comment.
change has been taken care.
kapilt
reviewed
Oct 31, 2022
cahn1
reviewed
Nov 4, 2022
| wafs = self.manager.get_resource_manager('wafv2').resources(augment=False) | ||
| waf_name_arn_map = {w['Name']: w['ARN'] for w in wafs} | ||
| target_acl_id = waf_name_arn_map.get(target_acl, target_acl) | ||
|
|
There was a problem hiding this comment.
@kk1532 ,
Since wafv2-enabled and set-wafv2 are common for cloudfront, appsync, can we make same logic? You can refer to pr/7706 for cloudfront wafv2-enabled as well.
There was a problem hiding this comment.
@cahn1 wafv2-enabled filter has been updated with cloudfront logic.
|
@kapilt can you please check out the updated code when you get a chance? CC: @kk1532 @darrendao @cahn1 |
|
… On Mon, Nov 21, 2022 at 4:12 PM Steven ***@***.***> wrote:
@kapilt <https://github.com/kapilt> can you please check out the updated
code when you get a chance?
CC: @kk1532 <https://github.com/kk1532> @darrendao
<https://github.com/darrendao> @cahn1 <https://github.com/cahn1>
—
Reply to this email directly, view it on GitHub
<#7946 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFJESGOJHW2UT6VZY3XSDWJPQU7ANCNFSM6AAAAAARQET4WU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
thisisshi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added regex feature to wafv2-enabled filter of rest-stage.
This fix supports local WAF and FMS based WAF.
Also Added set-wafv2 filter to support regex format.