Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - s3 - handle access denied errors in check-public-block filter #8374

Merged
merged 6 commits into from Mar 14, 2023
Merged

aws - s3 - handle access denied errors in check-public-block filter #8374

merged 6 commits into from Mar 14, 2023

Conversation

ajkerrigan
Copy link
Member

Have the check-public-block filter log/warn/continue when it can't fetch the public block configuration for a bucket.

Closed #6678

@ajkerrigan ajkerrigan requested a review from kapilt as a code owner March 14, 2023 14:42
kapilt
kapilt approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit c121184 into cloud-custodian:main Mar 14, 2023
20 checks passed
@ajkerrigan ajkerrigan deleted the s3-check-public-block-errorhandling branch March 14, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s3 filter check-public-block causes c7n to fail to scan remaining buckets when it encounters an access denied
2 participants
@ajkerrigan @kapilt