New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp - add artifact-repository resource #8444
Merged
kapilt
merged 14 commits into
cloud-custodian:main
from
evhenyshaliov:artifactregistry-repository
May 5, 2023
Merged
gcp - add artifact-repository resource #8444
kapilt
merged 14 commits into
cloud-custodian:main
from
evhenyshaliov:artifactregistry-repository
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this has a pre-requisite on the gcp-region resource |
kapilt
reviewed
May 5, 2023
… simplify testing, remove untested gcp iam policy filter
kapilt
changed the title
gcp - added the artifactregistry-repository resource and gcp-iam-policy-filter
gcp - add artifactregistry-repository resource
May 5, 2023
kapilt
changed the title
gcp - add artifactregistry-repository resource
gcp - add artifact-repository resource
May 5, 2023
pulling the gcp iam filter out per previous comments as it needs additional work, to enable merging artifact repository as is. |
kapilt
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
policies: - name: epam-gcp-307-artifact-registry-repository-is-not-anonymously-or-publicly-accessible description: | GCP Artifact Registry repository is anonymously or publicly accessible resource: gcp.artifactregistry-repository filters: - type: gcp-iam-policy-filter key: members value: [allUsers,allAuthenticatedUsers] op: intersect