Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp - add artifact-repository resource #8444

Merged

Conversation

evhenyshaliov
Copy link
Collaborator

@evhenyshaliov evhenyshaliov commented Mar 30, 2023

Use case:

policies: - name: epam-gcp-307-artifact-registry-repository-is-not-anonymously-or-publicly-accessible description: | GCP Artifact Registry repository is anonymously or publicly accessible resource: gcp.artifactregistry-repository filters: - type: gcp-iam-policy-filter key: members value: [allUsers,allAuthenticatedUsers] op: intersect

@kapilt
Copy link
Collaborator

kapilt commented Mar 30, 2023

this has a pre-requisite on the gcp-region resource

kapilt added 2 commits May 5, 2023 08:46
… simplify testing, remove untested gcp iam policy filter
@kapilt kapilt changed the title gcp - added the artifactregistry-repository resource and gcp-iam-policy-filter gcp - add artifactregistry-repository resource May 5, 2023
@kapilt kapilt changed the title gcp - add artifactregistry-repository resource gcp - add artifact-repository resource May 5, 2023
@kapilt
Copy link
Collaborator

kapilt commented May 5, 2023

pulling the gcp iam filter out per previous comments as it needs additional work, to enable merging artifact repository as is.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapilt kapilt merged commit 4a3c396 into cloud-custodian:main May 5, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants