Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS - SES - Create new resource type configuration-set for SES #8457

Merged
merged 4 commits into from Apr 13, 2023
Merged

AWS - SES - Create new resource type configuration-set for SES #8457

merged 4 commits into from Apr 13, 2023

Conversation

peterheo
Copy link
Contributor

Creating a new resource type for the SES service.

@peterheo peterheo requested a review from kapilt as a code owner March 31, 2023 18:54
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

PratMis
PratMis approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@PratMis PratMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@PratMis
Copy link
Collaborator

PratMis commented Apr 12, 2023

@ajkerrigan / @thisisshi, when you get a chance, do you mind taking a look at it one more time. Code looks good to me, I also went ahead and tested the tagging functionality and can confirm that the resource supports resourcegroupstagging api. Thanks :)

ajkerrigan
ajkerrigan requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the core looks good to me. Suggestion inline to avoid including noise or duplicate data during augment.

c7n/resources/ses.py Outdated Show resolved Hide resolved
@peterheo @ajkerrigan
Remove unwanted keys in resource details
894faae 
Co-authored-by: AJ Kerrigan <aj@speckledmonkey.com>
PratMis
PratMis approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@PratMis PratMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @peterheo and @ajkerrigan

ajkerrigan
ajkerrigan approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterheo and @PratMis 🙌

@ajkerrigan ajkerrigan merged commit d6bb9cf into cloud-custodian:main Apr 13, 2023
21 checks passed
@peterheo peterheo deleted the ses branch May 16, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkerrigan ajkerrigan ajkerrigan approved these changes

@PratMis PratMis PratMis approved these changes

@kapilt kapilt Awaiting requested review from kapilt kapilt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterheo @PratMis @ajkerrigan