Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp - added gce-project, regions #8461

Merged
merged 11 commits into from May 5, 2023
Merged

Conversation

evhenyshaliov
Copy link
Collaborator

Use cases:

  • regions are required for artifactregistry
policies:
  - name: epam-oslogin-disables
    description: |
      OS Login is not enabled for a Project
    resource: gcp.gce-project
    filters:
      - not:
          - type: value
            key: commonInstanceMetadata.items[?key == `enable-oslogin`].value
            value:
              - "TRUE"
              - "True"
              - "true"
            op: intersect

@kapilt
Copy link
Collaborator

kapilt commented Apr 10, 2023

I do wonder if we should just statically do the gcp regions as internal data feed we update with dependency tree before releases, maybe using this as a feed https://www.gstatic.com/ipranges/cloud.json

@kapilt
Copy link
Collaborator

kapilt commented Apr 25, 2023

per offline discussion a two weeks back, I went ahead and added #8517 to model regions independently of making an api call. we should remove zones from this.

@evhenyshaliov evhenyshaliov changed the title gcp - added gce-project, regions, zones gcp - added gce-project, regions Apr 26, 2023
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 38774f2 into cloud-custodian:main May 5, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants