New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp - added gce-project, regions #8461
Conversation
I do wonder if we should just statically do the gcp regions as internal data feed we update with dependency tree before releases, maybe using this as a feed https://www.gstatic.com/ipranges/cloud.json |
per offline discussion a two weeks back, I went ahead and added #8517 to model regions independently of making an api call. we should remove zones from this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Use cases: