core - don't expand {now} placeholder during provisioning #8509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Apr 20, 2023
ajkerrigan
force-pushed
the
expand-now-at-runtime
branch
2 times, most recently
from
7a33b8f
to
e486aa0
Compare
kapilt
reviewed
May 5, 2023
ajkerrigan
force-pushed
the
expand-now-at-runtime
branch
from
b7fc104
to
28763d4
Compare
|
we should probably have a test here wrt to the current work around re double escape Ala {{now}} as we to validate not breaking extant behavior. |
Fair point, added that case. |
kapilt
reviewed
May 9, 2023
kapilt
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we expand the
{now}placeholder when a policy executes, regardless of whether we're provisioning a policy or actually running it. This change lets us defer expansion while preserving custom format specifiers.There may be a more straightforward way to do this...
Closes #8503