Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - add pinpoint resource #8514

Merged
merged 7 commits into from May 1, 2023
Merged

aws - add pinpoint resource #8514

merged 7 commits into from May 1, 2023

Conversation

timmygrable
Copy link
Contributor

Closes #8495

@PratMis
Copy link
Collaborator

PratMis commented Apr 25, 2023

The get_apps api call here seems to be returning tags but they are not in a format that custodian uses. If you look at other resources, the Tags come back as Tags: [{Key: xyz, Value: abc}]. You may need an augment function to fix the format here

PratMis
PratMis approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@PratMis PratMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

ajkerrigan
ajkerrigan approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

c7n/resources/pinpoint.py Show resolved Hide resolved
@ajkerrigan ajkerrigan merged commit dee914d into cloud-custodian:main May 1, 2023
21 checks passed
@timmygrable timmygrable deleted the add-pinpoint-resource branch May 1, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkerrigan ajkerrigan ajkerrigan approved these changes

@PratMis PratMis PratMis approved these changes

@kapilt kapilt Awaiting requested review from kapilt kapilt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws - Pinpoint resource support
3 participants
@timmygrable @PratMis @ajkerrigan