Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - post-finding - document usage of the title parameter #8527

Merged
merged 4 commits into from
May 4, 2023
Merged

aws - post-finding - document usage of the title parameter #8527

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32878b7
aws - post-finding - document usage of the title parameter
ajkerrigan May 1, 2023
fe5c21f
Merge branch 'main' into docs/sechub-update-finding
ajkerrigan May 1, 2023
986a0b8
Merge branch 'main' into docs/sechub-update-finding
ajkerrigan May 3, 2023
9f516c7
Merge branch 'main' into docs/sechub-update-finding
ajkerrigan May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion c7n/resources/securityhub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,9 @@ class PostFinding(Action):
https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-findings-format.html

For resources that are taggable, we will tag the resource with an identifier
such that further findings generate updates.
such that further findings generate updates. The name of the tag comes from the ``title``
parameter of the ``post-finding`` action, or the policy name if ``title`` is empty. This
allows different policies to update the same finding if they specify the same ``title``.

Example generate a finding for accounts that don't have shield enabled.

Expand All @@ -355,6 +357,7 @@ class PostFinding(Action):
- "Software and Configuration Checks/Industry and Regulatory Standards/NIST CSF Controls (USA)"
recommendation: "Enable shield"
recommendation_url: "https://www.example.com/policies/AntiDDoS.html"
title: "shield-enabled"
confidence: 100
compliance_status: FAILED

Expand Down