Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resources for cdn customdomain and cdn endpoint #8554

Merged
merged 5 commits into from May 18, 2023
Merged

Added resources for cdn customdomain and cdn endpoint #8554

merged 5 commits into from May 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2023

No description provided.

Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me 👍 .

One thing I'm not sure about - the resource naming looked a bit rough to parse at a glance (cdncustomdomain as compared to kebab-style cdn-custom-domain for example). I see examples of both conventions in the existing Azure resource list though, and even a few cases where we support both (sqlserver is an alias for sql-server, for example).

I'll bring this up in our community meeting later today since I'm leaning toward requesting kebab case but other folks may have reasons or context I'm missing.

@ghost
Copy link
Author

ghost commented May 18, 2023

Thanks, this looks good to me 👍 .

One thing I'm not sure about - the resource naming looked a bit rough to parse at a glance (cdncustomdomain as compared to kebab-style cdn-custom-domain for example). I see examples of both conventions in the existing Azure resource list though, and even a few cases where we support both (sqlserver is an alias for sql-server, for example).

I'll bring this up in our community meeting later today since I'm leaning toward requesting kebab case but other folks may have reasons or context I'm missing.

Than you @ajkerrigan I have updated the policy name to kebab-style.

@ghost ghost requested a review from ajkerrigan May 18, 2023 13:20
Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you're ahead of me 😅 . Looks good!

@ajkerrigan ajkerrigan merged commit 1628b5e into cloud-custodian:main May 18, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant