Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-azure-resources-to-support-spring-apps #8558

Conversation

hiteshmck
Copy link
Contributor

Currently there are no c7n azure resource to support Azure Spring Apps related resources. This PR creates 2 resources spring-service-instance and spring-app, so support policies around this.

spring-service-instance will be the parent resource for spring-app

@kapilt
Copy link
Collaborator

kapilt commented May 12, 2023

lgtm, but can we keep both of these in the same module (say spring.py)

@hiteshmck
Copy link
Contributor Author

lgtm, but can we keep both of these in the same module (say spring.py)

@kapilt Thx, I put them both in the same module spring.py.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit d364c2f into cloud-custodian:main May 15, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants