releng - require urllib3 <2.0 to speed up dependency resolution #8563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating dependencies currently takes a very long time (20+ minutes) because: - docker/requests/twine/botocore all depend on urllib3 - everyone _except_ botocore is happy with urllib3 2.x - poetry initially selects urllib3 2.x, and churns through hundreds of botocore versions before deciding to try an earlier version We could also try to handle this by tweaking our boto3 constraint, but this seems like an explicit way to avoid a lot of running into walls.
ajkerrigan
added a commit
to ajkerrigan/cloud-custodian
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependencies currently takes a very long time (20+ minutes) because:
We could also try to handle this by tweaking our boto3 constraint, but this seems like an explicit way to avoid a lot of running into walls.