Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS Inspector v2 resource, updated iam-actions and fixed tests #8934

Merged
merged 3 commits into from Sep 19, 2023

Conversation

im4kv
Copy link
Contributor

@im4kv im4kv commented Sep 10, 2023

Hi,
This includes the following changes:

  • Addition of AWS Inspector V2 findings as a new resource. findings can be filtered using the API filterCriteria parameter.
  • As a result of this addition, I had to update iam-actions.json to include permissions for it.
  • AWS connect service permissions updated to include new AWS permission prefix available in iam-actions.json.
  • Since now we have more than three actions for account resource. I updated test_data.py to be compliant with returned list of actions.

updated iam-actions to include new services including Inspector2.
fixed permission changes for connect resource and update data tests regarding iam-actions.
@im4kv im4kv requested a review from kapilt as a code owner September 10, 2023 14:51
@kapilt
Copy link
Collaborator

kapilt commented Sep 12, 2023

thanks for the pr, we had stalled data only pr update, in #8820, let me try to get that in, independently, we try not to mix those prs in with features.

@im4kv
Copy link
Contributor Author

im4kv commented Sep 12, 2023

thanks for the pr, we had stalled data only pr update, in #8820, let me try to get that in, independently, we try not to mix those prs in with features.

Hi @kapilt , you're welcome.
that would be great since it won't allow adding new resources.
I will watch that PR now and will update this one when it has been merged

@kapilt
Copy link
Collaborator

kapilt commented Sep 18, 2023

the separate data dictionaries pr was merged so those changes can be removed from this pr.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks. it might be interesting to expose this as a filter on ec2 resources in the future.

@im4kv
Copy link
Contributor Author

im4kv commented Sep 18, 2023

thanks for updating the PR,
Yeah, that's a good filter, there are other Inspector2 API calls that might be interesting to add (e.g. aggregated results by account, instance, vulnerability, list of instances with status, etc.).

@kapilt kapilt merged commit 6938077 into cloud-custodian:main Sep 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants