Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng - update custodian version in dependent packages #9025

Merged
merged 1 commit into from Oct 3, 2023

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Oct 3, 2023

we had separate pkg-increment and pkg-rebase prs, but increment needs an update
of c7n in all dependent packages to get the lockfile to update, else they still point
to the last release.

Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that makes sense, good catch 👍

@kapilt
Copy link
Collaborator Author

kapilt commented Oct 3, 2023

alternatively we should document that rebase has to always run after increment is merged

@ajkerrigan
Copy link
Member

alternatively we should document that rebase has to always run after increment is merged

Hmm, along those lines maybe an automated release check to look at the c7n version in pyproject.toml and make sure it matches the poetry.lock c7n version for all dependent packages. Would probably be a useful check.

@kapilt
Copy link
Collaborator Author

kapilt commented Oct 3, 2023

alternatively we should document that rebase has to always run after increment is merged

Hmm, along those lines maybe an automated release check to look at the c7n version in pyproject.toml and make sure it matches the poetry.lock c7n version for all dependent packages. Would probably be a useful check.

I mean technically the release automation did catch the issue, it uploads all the built wheels to a test pypi and tries to install. an explicit check would in automation would perhaps give a clearer error message earlier, but if we're going to tailor to the issue, having make pkg-increment do the update seems better (ie automate the problem away).

@kapilt kapilt merged commit 7be74ff into cloud-custodian:main Oct 3, 2023
12 checks passed
@kapilt kapilt deleted the releng/release-prep-0.9.32-p2 branch October 3, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants