aws - elasticsearch - fix error handling of boto3 #9070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo of ResourceNotFoundException
- AddTags and RemoveTags appear to throw ValidationExceptions rather than ResourceNotFound when targeting a non-existent domain - The cross-cluster filter uses a filter parameter on the underlying API call, so when looking for a non-existent domain it will return an empty result set rather than throwing an error
|
Hey @DawnElixir good catch on the typo there, thanks for filing! While adding tests for this I realized that fixing the typo didn't fix the behavior. Because:
So I've added a test for tagging/untagging a non-existent domain and tweaked the logic as needed. It looks like we already have something that tries to cover the cross-cluster piece. |
ajkerrigan
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error handling of boto3 exception ResourceNotFoundException