Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - secrets manager tag, ignore reserved tags #9110

Merged
merged 2 commits into from
Oct 27, 2023
Merged

aws - secrets manager tag, ignore reserved tags #9110

merged 2 commits into from
Oct 27, 2023

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Oct 26, 2023

closes #9093

PratMis
PratMis approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@PratMis PratMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 942ddf5 into cloud-custodian:main Oct 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratMis PratMis PratMis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws.secrets-manager:tag action tries to retag secret with existing tags as well
2 participants
@kapilt @PratMis