added PendingMaintenanceActionDetails details to describe_pending_mai… #9183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntenance_actions call
|
Hi @darrendao @kapilt @thisisshi, can you review the PR when you get a chance, thanks. |
darrendao
reviewed
Dec 12, 2023
|
@kapilt @ajkerrigan can you please review/approve this one before next release? CC: @darrendao |
ajkerrigan
approved these changes
Jan 5, 2024
|
|
||
| for r in resources: | ||
| if r['DBInstanceArn'] in pending_maintenance: | ||
| pending_maintenances = resource_maintenances.get(r['DBInstanceArn'], []) | ||
| if len(pending_maintenances) > 0: |
There was a problem hiding this comment.
nit: a truthiness check would be sufficient here and possibly clearer
Suggested change
| if len(pending_maintenances) > 0: | |
| if pending_maintenances: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added PendingMaintenanceActionDetails details to describe_pending_maintenance_actions call