Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure.vm.filters.backup-status #9242

Merged
merged 6 commits into from Jan 30, 2024

Conversation

dmytro-afanasiev
Copy link
Collaborator

@dmytro-afanasiev dmytro-afanasiev commented Jan 12, 2024

azure.vm.filters.backup-status

policies:
  - name: asb_vm_backup
    description: |
      Virtual machine without Backup configured
    resource: azure.vm
    filters:
      - not:
          - type: backup-status
            protection-status: Protected

@dmytro-afanasiev dmytro-afanasiev changed the title azure.vm.filters.backup-status and azure.vm.filters.security-jit-policy azure.vm.filters.backup-status Jan 12, 2024
@kapilt
Copy link
Collaborator

kapilt commented Jan 29, 2024

@dmytro-afanasiev I updated the pr to address a common issue I've seen in some of the azure prs, namely subclassing value filter, but not exposing any of the value filter functionality, but instead hardcoding behavior to a single attribute. in general we want to expose the value filter semantics against all the attributes of the related object.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapilt kapilt merged commit 5b4ea71 into cloud-custodian:main Jan 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants