aws - ec2 resize from cost hub recommendation #9281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
commented
Feb 8, 2024
|
|
||
| def process(self, resources, event=None): | ||
| client = local_session(self.manager.session_factory).client('cost-optimization-hub') | ||
| client = local_session(self.manager.session_factory).client( | ||
| 'cost-optimization-hub', region_name='us-east-1') |
There was a problem hiding this comment.
the endpoint for hub is only in us-east-1, that endpoint does hold data for other regions
ajkerrigan
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Sweet, looks good to me 👍
I did wonder if it was too magical that the resize action would automatically pull an instance type from hub recommendations (as opposed to explicitly opting in like we do with values like matched in other filter-->action relationships).
But I think the magic seems pretty nice here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having to provide type map and default, support usage
with cost optimization hub for automatic resizing.