Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws - Added new action and a bugfix for existing action for route53 #9291
aws - Added new action and a bugfix for existing action for route53 #9291
Changes from 50 commits
ac6a60f
38fccf4
6f77ff9
534b6d4
984c4e4
706066f
9154b66
bd19ac3
5af0950
dca7f73
123fcb8
d9ac956
0bdd999
2d10cad
ba317f2
ec003bc
ec6afe8
d35d6ca
79da095
ff4a237
c7720fb
31ad0a7
8073a4f
90c5c10
a68d0a1
d689fc3
1f73ce5
fab4998
7bf8039
7abfe20
3621f2d
f312f10
eb2a6b2
ecb5ecc
fb0c630
1dcfc08
c971442
59d7599
f605a5b
ad2a776
fb695c9
d6463b1
4a61ac2
e5784db
8ecb355
4a172e4
8149850
622430a
0cd1bfd
8ba52cb
9179a6e
b18d91d
6160d02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 243 in c7n/resources/route53.py
Codecov / codecov/patch
c7n/resources/route53.py#L243
Check warning on line 259 in c7n/resources/route53.py
Codecov / codecov/patch
c7n/resources/route53.py#L258-L259
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like since we now have a delete record set action, we could remove that implementation from here and just call the delete action on the record set, composition style to avoid the duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kapilt
Can you check and confirm, are below the expected change?
on @HostedZone.action_registry.register('delete')
class Delete(BaseAction):
and remove the method def delete_records(self, client, hz):
add equivalent entry on record set delete action like below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this composition style, we can avoid two delete implementation for record deletion.