Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscc - update action - ensure patch only against updatable properties #9297

Merged
merged 6 commits into from Feb 21, 2024

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Feb 15, 2024

closes #9296

Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question inline around the need for deepcopy, otherwise lgtm once checks are passing 👍

tools/c7n_awscc/c7n_awscc/actions.py Outdated Show resolved Hide resolved
Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! 🎉

Two things I was noodling on were:

  • Would this make more sense as a separate patch action?
    • Probably not
  • Can we make this a bit more streamlined for policy authors rather than exposing full/explicit jsonpatch syntax?
    • Maaaybe, but the cost would be making things less obvious or too magical, particularly for the op: remove case

@kapilt
Copy link
Collaborator Author

kapilt commented Feb 21, 2024

@ajkerrigan I think you answered your own questions ;-) but let me know if you want some additional context. fwiw, we might need to extend this action in the future to take into consideration in flight operations to the resources.

@kapilt kapilt merged commit 4dfb8c3 into cloud-custodian:main Feb 21, 2024
22 checks passed
@kapilt kapilt deleted the awscc/update-fix-props branch February 21, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Athena Workgroup Encryption also tries to change readonly field
2 participants