Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - add cwa filter for alarms that have a parent composite alarm #9300

Merged
merged 10 commits into from Feb 23, 2024
Merged

aws - add cwa filter for alarms that have a parent composite alarm #9300

merged 10 commits into from Feb 23, 2024

Conversation

timmygrable
Copy link
Contributor

Closes #9299

@timmygrable timmygrable marked this pull request as draft February 16, 2024 17:21
@timmygrable
Copy link
Contributor Author

Putting into draft - misunderstood the ask for this PR

@timmygrable timmygrable changed the title aws - add composite alarm filter for cloudwatch alarms aws - add cwa filter for alarms that have a child composite alarm Feb 16, 2024
@timmygrable timmygrable changed the title aws - add cwa filter for alarms that have a child composite alarm aws - add cwa filter for alarms that have a parent composite alarm Feb 16, 2024
PratMis
PratMis reviewed Feb 16, 2024
View reviewed changes
c7n/resources/cw.py Outdated Show resolved Hide resolved
@timmygrable timmygrable marked this pull request as ready for review February 16, 2024 19:07
PratMis
PratMis reviewed Feb 16, 2024
View reviewed changes
c7n/resources/cw.py Outdated Show resolved Hide resolved
@PratMis
Copy link
Collaborator

PratMis commented Feb 16, 2024 •
edited

Honestly, I think it might be better to do is-composite-child with a boolean state: True/False

kapilt
kapilt reviewed Feb 20, 2024
View reviewed changes
c7n/resources/cw.py Outdated Show resolved Hide resolved
PratMis
PratMis reviewed Feb 21, 2024
View reviewed changes
c7n/resources/cw.py Outdated Show resolved Hide resolved
PratMis
PratMis approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@PratMis PratMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

kapilt
kapilt approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, my only question is if we also want to annotate the composite alarm names onto the child alarms, since we have the information on hand.

@kapilt kapilt merged commit ea06851 into cloud-custodian:main Feb 23, 2024
22 checks passed
@timmygrable timmygrable deleted the cloudwatch-composite-alarm-filter branch February 23, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

@PratMis PratMis PratMis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws - cloudwatch alarms add support to filter out alarms with a parent composite alarm
3 participants
@timmygrable @PratMis @kapilt