Add snapshots filter to azure.disk

[dmytro-afanasiev]

Example:

policies:
  - name: disk-without-snapshots-within-14days
    resource: azure.disk
    filters:
      - type: snapshots
        attrs:
          - type: value
            key: properties.timeCreated
            value_type: age
            value: 14
            op: le
        count: 0

[dmytro-afanasiev]

@kapilt, hello, could you please tell whether the policy in example would work as the name suggests? Because i'm not sure whether the count is applied after performing all filtering by attrs

[kapilt]

this feels like it should use the resource manager for snapshots to take advantage of the catch. alternatively if the cardinality on resources is small, it might be something to fetch per volume. additionally rather than iterating over the snapshot list for each volume (n*m) using a map that keys off the uniqueId would greatly reduce iterations

[dmytro-afanasiev]

Thank you for feedback!

• Not sure what use the resource manager for snapshots to take advantage of the catch means. Does it mean i should create a separate resource type called smt like azure.snapshot and somehow utilize it for this filter? Or should i keep the result of client.snapshots.list() in a class attribute in order not to make this request each time process() is called?

• as far as i investigated we cannot fetch snapshots for a specific volume. We can only retrieve all snapshots within a subscription/resource-group and then filter out those that belong to a specific disk (https://learn.microsoft.com/en-us/python/api/azure-mgmt-compute/azure.mgmt.compute.v2020_12_01.operations.snapshotsoperations?view=azure-python)

• using map - ok, i'll do that